fix(destination): prevent task leak in federated service watchers #14693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lock indefinitely When unsubscribing a stream from a federated service, we: 1. For each cluster, send an update on the stream's channel to remove endpoints. 2. Call synchronizedGetStream.Stop() so that it stops processing updates. These steps can race and deadlock: if Stop() has been called before endoint updates are processed, the subsequent Send() calls block forever. This change improves test coverage to cover this case as well as that fixed in f4e6795.
olix0r
changed the title
olix0r
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR adds robust error handling to synchronizedGetStream.Send() to prevent goroutine leaks when the stream is stopped, along with comprehensive test coverage for the new behavior.
- Modified
Send()method to returnerrStreamStoppederror when called afterStop(), preventing indefinite blocking - Added two test cases verifying that
Send()returns promptly afterStop()is called, even when the inner stream is blocked
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| controller/api/destination/syncronized_get_stream.go | Updated Send() method with graceful shutdown logic using select statements to check if stream is stopped before and during channel send operations |
| controller/api/destination/syncronized_get_stream_test.go | Added comprehensive test coverage with two test functions and a blocking mock server to verify Send behavior after Stop is called |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
zaharidichev
approved these changes
Nov 6, 2025
Member
zaharidichev
left a comment
zaharidichev
left a comment
There was a problem hiding this comment.
LGTM. Solid test coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unsubscribing a stream from a federated service, we:
These steps can race and deadlock and task leak: if Stop() has been called before endoint updates are processed, the subsequent Send() calls block forever.
This change improves test coverage to cover this case as well as that fixed in f4e6795.